Make extension config override instead of deep merge #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverJAsh
commented
Sep 11, 2019
| resolved "https://registry.yarnpkg.com/which/-/which-1.2.14.tgz#9a87c4378f03e827cecaf1acdf56c736c01c14e5" | ||
| dependencies: | ||
| isexe "^2.0.0" | ||
|
|
There was a problem hiding this comment.
FYI, a bunch of these changes are from running yarn-deduplicate.
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
====================================
Coverage 0% 0%
====================================
Files 4 4
Lines 129 129
Branches 52 52
====================================
Misses 129 129Continue to review full report at Codecov.
|
OliverJAsh
commented
Sep 11, 2019
| ...base.compilerOptions, | ||
| ...config.compilerOptions | ||
| } | ||
| }; |
There was a problem hiding this comment.
Are there any other nested properties we need to override?
I wondered if there was a way to do this automatically, but I think we have to be selective about which nested properties should be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94