Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the root path #180

Merged
merged 3 commits into from Mar 13, 2022
Merged

Fix the root path #180

merged 3 commits into from Mar 13, 2022

Conversation

benevbright
Copy link
Contributor

fixes #128

@rattrayalex
Copy link

Also fixes #113

@jonaskello
Copy link
Member

There seems to be a demand for this in both #113 and #128 so it would of course be nice to have it merged.

@benevbright could you also add some tests for both the positive and negative cases of this?

@benevbright
Copy link
Contributor Author

@jonaskello I've added a test. Thanks! 👍

@jonaskello jonaskello merged commit 02c37bc into dividab:master Mar 13, 2022
@jonaskello
Copy link
Member

Released in 3.14.0

@khalidKhaliqi
Copy link

@benevbright really appreciate this fix!!! helps resolve issues when executing lambdas with layers where lambdas must reference modules using /op/nodejs and tsconfig.json manages the mapping like: /opt/nodejs --> src/common etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work for path mapping starting with /
4 participants