Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimist vulnerability CVE-2021-44906 #195

Closed
IronGeek opened this issue Mar 22, 2022 · 5 comments
Closed

Minimist vulnerability CVE-2021-44906 #195

IronGeek opened this issue Mar 22, 2022 · 5 comments

Comments

@IronGeek
Copy link

Please bump tsconfig-paths dependencies.

minimist <=v1.2.5 brings in security vulnerability which affect all packages that depends on tsconfig-paths, including the json5 package also used in this package.

json5 already addresses this minimist issue in their latest version v2.2.1.
As for minimist it self, based on discussion here a migration to an alternative package or other up-to-date fork maybe needed.

@IronGeek
Copy link
Author

minimist has released new version to address the security issue.
So I guess the only thing left todo is just bumping the minimist version in tsconfig-paths to v1.2.6

@F3n67u
Copy link
Contributor

F3n67u commented Mar 25, 2022

this issue is already fixed by #197

@jon-shipley
Copy link

I am waiting on the the json5@1.0.1 dependency to be updated. As the original comment says, the latest json5 version is v2.2.1

If there is a work-around please do let me know.

@lightzane
Copy link

@F3n67u it seems that the issue did not actually got fixed by #197
Upon checking npm ls json5, the tsconfig-paths@3.14.1 is still depending on json5@1.0.1

image

@IronGeek
Copy link
Author

IronGeek commented Sep 3, 2022

I'm closing this since all the problematic dependencies have been updated in v4.
Related PR: #197, #198

@IronGeek IronGeek closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants