Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show problematic file path when encountering malformed JSON5 #176

Merged
merged 3 commits into from May 3, 2022

Conversation

fwouts
Copy link
Contributor

@fwouts fwouts commented Sep 14, 2021

In a large codebase with lots of tsconfig.json extending each other, when JSON5 parsing crashes, it can be unclear which tsconfig file was problematic. This should help point out the issue more easily.

Note: all formatting changes were caused by the pre-commit hook. I'd be happy to force-revert them if desired.

@jonaskello
Copy link
Member

@fwouts Could you merge with master and push? After that I think we should be good to merge this.

@fwouts
Copy link
Contributor Author

fwouts commented May 2, 2022

Done! Better late than never 🥳

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #176 (f183055) into master (9a3c0ed) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   67.76%   67.97%   +0.21%     
==========================================
  Files           9        9              
  Lines         304      306       +2     
  Branches       93       93              
==========================================
+ Hits          206      208       +2     
  Misses         92       92              
  Partials        6        6              
Impacted Files Coverage Δ
src/tsconfig-loader.ts 84.37% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3c0ed...f183055. Read the comment docs.

@jonaskello jonaskello merged commit ebc0ed3 into dividab:master May 3, 2022
@jonaskello
Copy link
Member

Thanks!

@fwouts fwouts deleted the fail-with-error-filename branch May 4, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants