Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid asterisk match - modulepath not found #140

Open
willyboy opened this issue Sep 16, 2020 · 2 comments · May be fixed by #141
Open

Invalid asterisk match - modulepath not found #140

willyboy opened this issue Sep 16, 2020 · 2 comments · May be fixed by #141

Comments

@willyboy
Copy link

I have the path:

"@foo/*/bars": ["foo/*/bars.ts"]

This is not matching my import of "@foo/beer/bar". Instead, it's matching something like, beer/ba. It should be matching on the beer.
Solution:
In the matchStar function, substr is used. The code implies that substring is what was intended. Substr takes a number of characters. Substring matches two indices; start and end. When switching to substring, the code works as expected.

@willyboy willyboy linked a pull request Sep 16, 2020 that will close this issue
@willyboy
Copy link
Author

@jonaskello

@Mrtenz
Copy link

Mrtenz commented Feb 23, 2024

Ran into this problem too, and I can confirm that the PR fixes it. Little bit worried that this is still an open issue after ~3.5 years though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants