-
Notifications
You must be signed in to change notification settings - Fork 106
Add support for baseUrl overwrite using TS_NODE_BASEURL environment v… #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 4 4
Lines 129 129
Branches 52 52
======================================
Misses 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, really looking forward for this update.
{
"ts-node": {
"compilerOptions": {
"baseUrl": "overridden for ts-node"
}
},
"compilerOptions: {
"baseUrl": "this one is used by tsc"
// ...
} // detect ts-node and get options
process[Symbol.for('ts-node.register.instance')].config.options |
Seems like some ppl find this useful so I will merge it. |
However there seems to be some merge conflicts that needs attending to first. |
Hi, Any updates on this? I'd appreciate it if you could merge/release this as soon as possible. |
If someone could resolve the conflicts a merge would be possible. |
@jonaskello |
@information-security Yes, please make a new PR. |
Superseded by #185 |
Adds support for baseUrl overwrite using
TS_NODE_BASEURL
environment variable.First off, thanks for this library! It seems that several people are running into a case where they need to change the
baseUrl
to get this working after runningtsc
. So far most of the solutions look to be either:baseUrl
tsconfig.json
to extend the orginaltsconfig.json
and then setbaseUrl
based on thatIt seems like the simplest solution would be to allow changing the baseUrl via environment variable instead of either of the above options.