Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/2.7 backport] fix markdown issues on configuration page #3073

Merged
merged 2 commits into from Dec 17, 2019
Merged

[release/2.7 backport] fix markdown issues on configuration page #3073

merged 2 commits into from Dec 17, 2019

Conversation

thaJeztah
Copy link
Member

Backports of:

vishesh92 and others added 2 commits December 16, 2019 13:22
@vishesh92 @thaJeztah
Fix cloudfront documentation formatting
c636ed7 
Signed-off-by: Vishesh Jindal <vishesh92@gmail.com>
(cherry picked from commit e1e72e9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@adrian-plata @thaJeztah
Fixing broken table
f999f54 
Signed-off-by: Adrian Plata <adrian.plata@docker.com>
(cherry picked from commit b4694b0)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @manishtomar @dmcgowan ptal

dmcgowan
dmcgowan approved these changes Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #3073 into release/2.7 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.7    #3073   +/-   ##
============================================
  Coverage        60.25%   60.25%           
============================================
  Files              103      103           
  Lines             8024     8024           
============================================
  Hits              4835     4835           
  Misses            2546     2546           
  Partials           643      643
Flag Coverage Δ
#linux 60.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269d18d...f999f54. Read the comment docs.

@dmcgowan dmcgowan merged commit cfd1309 into distribution:release/2.7 Dec 17, 2019
@thaJeztah thaJeztah deleted the 2.7_backport_table_fix branch December 17, 2019 09:21
@thaJeztah thaJeztah mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @dmcgowan @vishesh92 @adrian-plata