Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining v2 -> v3 changes in docs and configuration #4250

Open
12 tasks
thaJeztah opened this issue Jan 11, 2024 · 3 comments
Open
12 tasks

Fix remaining v2 -> v3 changes in docs and configuration #4250

thaJeztah opened this issue Jan 11, 2024 · 3 comments
Labels
area/config Related to registry config documentation

Comments

@thaJeztah
Copy link
Member

Description

I noticed some things that we need to address before v3.0.0 w.r.t. configuration or the official image, and documentation; this is just a quick list, but there may be more;

  • update the documentation to refer to the new image tag (documentation currently uses registry:2)
  • update the location of the configuration file (/etc/docker/registry/config.yaml)
  • verify the default configuration file in the official image. The registry-library-image has a default / example configuration file; https://github.com/distribution/distribution-library-image/blob/eb58390c830bc5017f1a4eafc365b45206ad21fe/config-example.yml. We need to;
    • verify if the example is still correct for v3 (is version 0.1 still accurate?)
    • do we have a canonical "default" config file in the main repository that we can use instead?
    • or; does the registry have an option to output the default config (similar to containerd's containerd config default, which dumps the default config file)?
    • are any of the options specified different from built-in defaults?
    • if none are different from the default, can we remove the configuration file entirely?
@thaJeztah thaJeztah added documentation area/config Related to registry config labels Jan 11, 2024
@thaJeztah thaJeztah added this to the Registry/3.0.0 milestone Jan 11, 2024
@thaJeztah
Copy link
Member Author

cc @milosgajdos @dvdksn @Jamstah

@milosgajdos
Copy link
Member

milosgajdos commented Jan 13, 2024

🫠 I wonder if we should create v3-stable Mileston in GH to track there

@Jamstah
Copy link
Collaborator

Jamstah commented Jan 15, 2024

🫠 I wonder if we should create v3-stable Mileston in GH to track there

I think we can just reuse the 3.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Related to registry config documentation
Projects
None yet
Development

No branches or pull requests

3 participants