Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure agent profile is executed in agent container setup #3310

Open
portante opened this issue Mar 4, 2023 · 0 comments
Open

Ensure agent profile is executed in agent container setup #3310

portante opened this issue Mar 4, 2023 · 0 comments
Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images enhancement
Milestone

Comments

@portante
Copy link
Member

portante commented Mar 4, 2023

If we wanted to...we could set /opt/pbench-agent/profile as the entrypoint for the container, so that it is run automagically when the container is invoked. If we then tweaked that script to, as its last action, run ${@}, any command line provided to the container invocation would then be run in that environment.

That would remove the need for this step, and it would happen seamlessly and automatically for all uses of the container (unless someone overrode the entrypoint), which seems like a really useful idea, given the purpose of this container.

Thoughts? (If we didn't want to disturb /opt/pbench-agent/profile itself, we could wrap it in another script (a la the jenkins/runner) and point the entrypoint at that.)

Originally posted by @webbnh in #3259 (comment)

@portante portante added this to the v0.72 milestone Mar 4, 2023
@portante portante added this to To do in v0.72 via automation Mar 4, 2023
@portante portante added enhancement Agent Containerization Of and relating to the process of setting up and maintaining container images labels Mar 4, 2023
@portante portante modified the milestones: v0.72, v0.73 Mar 14, 2023
@portante portante removed this from To do in v0.72 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images enhancement
Projects
Status: To Do
Development

No branches or pull requests

1 participant