Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the _method function of Connection class in the auth module. #3253

Open
npalaska opened this issue Feb 13, 2023 · 0 comments
Open

Fix the _method function of Connection class in the auth module. #3253

npalaska opened this issue Feb 13, 2023 · 0 comments

Comments

@npalaska
Copy link
Member

It seems that any "loose" keywords here get bundled into request params, but I'm kinda surprised that nobody complained about how Connection._method accepts **kwargs and then uses that as one of several parameters to overwrite the local definition of kwargs as a dict of keyword parameters to request. Wow; that's twisted. Using a different name would have been better: it's really easy when skimming through to assume that the **kwargs in the request call is the same kwargs passed into _method. Ah well; that's not really in scope for this PR.

Originally posted by @dbutenhof in #3235 (comment)

@portante portante added this to the v0.72 milestone Feb 14, 2023
@portante portante added this to To do in v0.72 via automation Feb 14, 2023
@portante portante modified the milestones: v0.72, v0.73 Mar 14, 2023
@portante portante removed this from To do in v0.72 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

No branches or pull requests

2 participants