Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites need the ability to sync comments missed in webhook pushes #33

Open
ryanvalentin opened this issue Feb 14, 2018 · 16 comments
Open

Comments

@ryanvalentin
Copy link
Contributor

There are scenarios where a site will not receive webhook events for new comments to sync them:

  • Site enabled Disqus but didn't enable syncing before new comments were made
  • Failed requests at the time of push, or bugs

The enhancement here will be to provide a way of manually running a sync to make sure all comments are stored locally. This might also possibly include a recurring cron job to do the syncing as well.

@ryanvalentin ryanvalentin added this to the 3.1 Release milestone Feb 14, 2018
@seSze
Copy link

seSze commented Feb 21, 2018

we also need this feature, so if you need help please let me know

@e-m-m-a
Copy link

e-m-m-a commented Mar 6, 2018

OK, but manual mode is useless. Cron job is ok. Sync was working before fine before this round of plugin upgrades.

@ghost
Copy link

ghost commented Mar 25, 2018

I'm experiencing this issue as well. I was able to manually sync previously but since the last plugin update the comments aren't synching. I was directed here from disqus support saying that "there’s something on your site that is blocking the REST API endpoint that is responsible for enabling syncing."

Is there any idea when a fix will be available?

@e-m-m-a
Copy link

e-m-m-a commented Mar 25, 2018

Exactly. It is still broken. Support are no longer responding to my thread.

@jaryszek
Copy link

jaryszek commented Mar 25, 2018 via email

@peterszky
Copy link

I'm experiencing sync issue too, I sent full details about it to the support forums, contacted support through plugin, couldn't get a clear answer or solution, just the above mentioned "there’s something on your site that is blocking the REST API endpoint that is responsible for enabling syncing". But it's not true, it's not blocking! The syncing is working for about 2-3 minutes, then error occurs. I'm pretty sure this is because of the large amount of comments which are waiting to be synced. The problem occured AFTER an user deleted his/her Disqus user and tenthousands of comments tried to sync back.

“The webhook subscription for your forum Üllői út 129. (shortname: ulloiut129) to the endpoint at https://ulloi129.hu/wp-json/disqus/v1/sync/webhook has been disabled due to a large number of errors being returned from your endpoint.”

A think I managed to find where is the error:

Sun Mar 18 11:25:18.455181 2018] [:error] [pid 2876] [client 208.101.7.43:27665] Error checking in buffer: The buffer you checked in was not checked out
[Sun Mar 18 11:25:18.993774 2018] [:error] [pid 2755] [client 208.101.7.44:20547] Error checking in buffer: There are no checked out buffers

https://github.com/Automattic/jetpack/blob/master/sync/class.jetpack-sync-queue.php

at 419. row

private function validate_checkout( $buffer ) {

Full details:
https://wordpress.org/support/topic/questions-about-syncing/

@jaryszek
Copy link

jaryszek commented Mar 30, 2018 via email

@e-m-m-a
Copy link

e-m-m-a commented Mar 30, 2018 via email

@buysoap
Copy link

buysoap commented May 8, 2018

@ryanvalentin Have there been any updates to this issue? It's been open since February

@jaryszek
Copy link

jaryszek commented May 8, 2018 via email

@jaryszek
Copy link

jaryszek commented May 12, 2018 via email

@e-m-m-a
Copy link

e-m-m-a commented May 12, 2018 via email

@peterszky
Copy link

I think that the last plugin update fixed the sync stop isssue.

@e-m-m-a
Copy link

e-m-m-a commented May 25, 2018 via email

@iamkingsleyf
Copy link

following

@jaryszek
Copy link

jaryszek commented Nov 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@ryanvalentin @iamkingsleyf @seSze @peterszky @e-m-m-a @jaryszek @buysoap and others