Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

payload type consistency fixes #198

Merged
merged 6 commits into from Sep 7, 2022
Merged

payload type consistency fixes #198

merged 6 commits into from Sep 7, 2022

Conversation

mlnrDev
Copy link
Member

@mlnrDev mlnrDev commented Aug 31, 2022 •
edited

this PR fixes types of some payload fields to match the behavior of the Discord API.

@mlnrDev mlnrDev added this to the v1.0.0 milestone Aug 31, 2022
@mlnrDev mlnrDev marked this pull request as ready for review September 3, 2022 18:41
@mlnrDev mlnrDev requested a review from topi314 September 3, 2022 18:41
topi314
topi314 requested changes Sep 4, 2022
View reviewed changes
discord/channel_create.go Outdated Show resolved Hide resolved
discord/channel_create.go Outdated Show resolved Hide resolved
discord/channel_create.go Outdated Show resolved Hide resolved
discord/channel_create.go Outdated Show resolved Hide resolved
discord/channel_create.go Outdated Show resolved Hide resolved
discord/thread.go Outdated Show resolved Hide resolved
discord/thread.go Outdated Show resolved Hide resolved
discord/user.go Outdated Show resolved Hide resolved
discord/voice_state.go Outdated Show resolved Hide resolved
discord/voice_state.go Outdated Show resolved Hide resolved
@mlnrDev mlnrDev requested a review from topi314 September 4, 2022 17:20
topi314
topi314 requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor stuff I noticed

discord/application_command_update.go Outdated Show resolved Hide resolved
discord/application_command_update.go Outdated Show resolved Hide resolved
discord/application_command_update.go Outdated Show resolved Hide resolved
discord/application_command_update.go Outdated Show resolved Hide resolved
discord/guild.go Outdated Show resolved Hide resolved
discord/guild_scheduled_event.go Outdated Show resolved Hide resolved
@mlnrDev mlnrDev requested a review from topi314 September 7, 2022 12:34
@mlnrDev mlnrDev merged commit 766a27c into development Sep 7, 2022
@mlnrDev mlnrDev deleted the patch/payload-consistency branch September 7, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topi314 topi314 topi314 approved these changes

Assignees
No one assigned
Labels
t:rest type:enhancement type:refactor
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlnrDev @topi314