{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":222472755,"defaultBranch":"main","name":"rubocop-discourse","ownerLogin":"discourse","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-11-18T14:47:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3220138?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1709220481.0","currentOid":""},"activityList":{"items":[{"before":"f1a646e2a1014a24566f7d91a6ca84d3678b5ad7","after":"c5e33d9c11d2cfd26aa7edfa32ee565f5405b3a1","ref":"refs/heads/main","pushedAt":"2024-02-29T15:26:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add autocorrect to the FabricatorShorthand cop","shortMessageHtmlLink":"FEATURE: Add autocorrect to the FabricatorShorthand cop"}},{"before":"7622ae989c3cd1701b536f4b7f870d3ce26bfd56","after":null,"ref":"refs/heads/loic-add-autocorrect-to-fab-cop","pushedAt":"2024-02-29T15:26:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"}},{"before":"084d5f9bd1d67dfb90f189446e73a762d677cbe6","after":"7622ae989c3cd1701b536f4b7f870d3ce26bfd56","ref":"refs/heads/loic-add-autocorrect-to-fab-cop","pushedAt":"2024-02-29T15:17:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add autocorrect to the FabricatorShorthand cop","shortMessageHtmlLink":"FEATURE: Add autocorrect to the FabricatorShorthand cop"}},{"before":null,"after":"084d5f9bd1d67dfb90f189446e73a762d677cbe6","ref":"refs/heads/loic-add-autocorrect-to-fab-cop","pushedAt":"2024-02-29T15:15:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add autocorrect to the FabricatorShorthand cop","shortMessageHtmlLink":"FEATURE: Add autocorrect to the FabricatorShorthand cop"}},{"before":"0b1e14b2ca6dda0038ce41b1c9f671096d7381aa","after":null,"ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-28T15:46:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"}},{"before":"da85422ec001e274d670c721a882289a3b48e6e5","after":"f1a646e2a1014a24566f7d91a6ca84d3678b5ad7","ref":"refs/heads/main","pushedAt":"2024-02-28T15:46:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add cops for plugins\n\nThis patch adds some new rules to have saner defaults for our plugins.\nThese rules should help in particular with disabled plugins.\n\nThe new cops are:\n\n* Discourse/Plugins/CallRequiresPlugin: checks `requires_plugin` is\n  called in controllers.\n* Discourse/Plugins/DiscourseEvent: checks `on` is called instead of\n  `DiscourseEvent.on`.\n* Discourse/Plugins/NamespaceConstants: checks constants are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NamespaceMethods: checks methods are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NoMonkeyPatching: checks existing classes are not\n  patched in `plugin.rb` using `class_eval`.\n* Discourse/Plugins/UseRequireRelative: checks `load` is not used to\n  load dependencies.","shortMessageHtmlLink":"FEATURE: Add cops for plugins"}},{"before":"00b5b35da22da50b9244a0e66460a117397a4488","after":"0b1e14b2ca6dda0038ce41b1c9f671096d7381aa","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-28T14:45:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add cops for plugins\n\nThis patch adds some new rules to have saner defaults for our plugins.\nThese rules should help in particular with disabled plugins.\n\nThe new cops are:\n\n* Discourse/Plugins/CallRequiresPlugin: checks `requires_plugin` is\n  called in controllers.\n* Discourse/Plugins/DiscourseEvent: checks `on` is called instead of\n  `DiscourseEvent.on`.\n* Discourse/Plugins/NamespaceConstants: checks constants are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NamespaceMethods: checks methods are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NoMonkeyPatching: checks existing classes are not\n  patched in `plugin.rb` using `class_eval`.\n* Discourse/Plugins/UseRequireRelative: checks `load` is not used to\n  load dependencies.","shortMessageHtmlLink":"FEATURE: Add cops for plugins"}},{"before":"7309893013fc06de1f6259675786c1a558474d98","after":"00b5b35da22da50b9244a0e66460a117397a4488","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-28T14:44:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add cops for plugins\n\nThis patch adds some new rules to have saner defaults for our plugins.\nThese rules should help in particular with disabled plugins.\n\nThe new cops are:\n\n* Discourse/Plugins/CallRequiresPlugin: checks `requires_plugin` is\n  called in controllers.\n* Discourse/Plugins/CheckPluginIsEnabled: checks new methods added to\n  existing classes are verifying if the plugin is enabled or not.\n* Discourse/Plugins/DiscourseEvent: checks `on` is called instead of\n  `DiscourseEvent.on`.\n* Discourse/Plugins/NamespaceConstants: checks constants are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NamespaceMethods: checks methods are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NoMonkeyPatching: checks existing classes are not\n  patched in `plugin.rb` using `class_eval`.\n* Discourse/Plugins/UseRequireRelative: checks `load` is not used to\n  load dependencies.","shortMessageHtmlLink":"FEATURE: Add cops for plugins"}},{"before":"d40efb14d0cafab8a4760e86407a61d5a73df301","after":"7309893013fc06de1f6259675786c1a558474d98","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-26T15:31:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"FEATURE: Add cops for plugins\n\nThis patch adds some new rules to have saner defaults for our plugins.\nThese rules should help in particular with disabled plugins.\n\nThe new cops are:\n\n* Discourse/Plugins/CallRequiresPlugin: checks `requires_plugin` is\n  called in controllers.\n* Discourse/Plugins/CheckPluginIsEnabled: checks new methods added to\n  existing classes are verifying if the plugin is enabled or not.\n* Discourse/Plugins/DiscourseEvent: checks `on` is called instead of\n  `DiscourseEvent.on`.\n* Discourse/Plugins/NamespaceConstants: checks constants are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NamespaceMethods: checks methods are not defined\n  outside the plugin namespace.\n* Discourse/Plugins/NoMonkeyPatching: checks existing classes are not\n  patched in `plugin.rb` using `class_eval`.\n* Discourse/Plugins/UseRequireRelative: checks `load` is not used to\n  load dependencies.","shortMessageHtmlLink":"FEATURE: Add cops for plugins"}},{"before":"3e3e2b6207874633326db2212aa67871292c178a","after":"d40efb14d0cafab8a4760e86407a61d5a73df301","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-26T15:16:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: bump version","shortMessageHtmlLink":"WIP: bump version"}},{"before":"dde0c0720b088e82398bc25dd3a8a31dab4bbc29","after":"3e3e2b6207874633326db2212aa67871292c178a","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-26T15:15:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: add doc to cops","shortMessageHtmlLink":"WIP: add doc to cops"}},{"before":"be2937e0a1dc9929d35c0212840122097ed6dd1d","after":"dde0c0720b088e82398bc25dd3a8a31dab4bbc29","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-20T16:11:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: add CheckPluginIsEnabled cop","shortMessageHtmlLink":"WIP: add CheckPluginIsEnabled cop"}},{"before":"0c3dbd796068b36b3acdf13529d22b1d3cdb6907","after":null,"ref":"refs/heads/feature/fabricator-shorthand-cop","pushedAt":"2024-02-20T03:48:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Drenmi","name":"Ted Johansson","path":"/Drenmi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5259935?s=80&v=4"}},{"before":"30b29301e308eece3428d52b12f8a6830eda5cc0","after":"da85422ec001e274d670c721a882289a3b48e6e5","ref":"refs/heads/main","pushedAt":"2024-02-20T03:48:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Drenmi","name":"Ted Johansson","path":"/Drenmi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5259935?s=80&v=4"},"commit":{"message":"FEATURE: Add a cop that checks for potential fabricator shorthand use (#40)\n\nIn discourse/discourse#24314, @danielwaterworth introduced the ability to use #fab! with a shorthand when simply fabricating a vanilla record with the same name as the assigned let. This PR introduces a cop that highlights places where this shorthand can be used.","shortMessageHtmlLink":"FEATURE: Add a cop that checks for potential fabricator shorthand use (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2101449629\" data-permission-text=\"Title is private\" data-url=\"https://github.com/discourse/rubocop-discourse/issues/40\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/discourse/rubocop-discourse/pull/40/hovercard\" href=\"https://github.com/discourse/rubocop-discourse/pull/40\">…</a>"}},{"before":"76ca3a1409a2d36ebfd95dd89c54752ce420a4a1","after":"be2937e0a1dc9929d35c0212840122097ed6dd1d","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-19T15:45:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: handle class_eval on serializers","shortMessageHtmlLink":"WIP: handle class_eval on serializers"}},{"before":"9399744281e48428ea667366ec3d50efa92c25ef","after":"76ca3a1409a2d36ebfd95dd89c54752ce420a4a1","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-15T17:06:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: Add NoMonkeyPatching cop (not done yet)","shortMessageHtmlLink":"WIP: Add NoMonkeyPatching cop (not done yet)"}},{"before":"569c4fb56012cfa83e06a8e60ebeeab6b6a5d6a6","after":"9399744281e48428ea667366ec3d50efa92c25ef","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-13T16:52:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: Add UseRequireRelative cop","shortMessageHtmlLink":"WIP: Add UseRequireRelative cop"}},{"before":"33dc62a34b43077721166d363df533fc11ee143f","after":"569c4fb56012cfa83e06a8e60ebeeab6b6a5d6a6","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-13T10:22:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: ignore db fixtures","shortMessageHtmlLink":"WIP: ignore db fixtures"}},{"before":"7da11ac02791c4a97bd9140a2b5b0b8c17524328","after":"33dc62a34b43077721166d363df533fc11ee143f","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-13T09:56:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: ignore rake tasks","shortMessageHtmlLink":"WIP: ignore rake tasks"}},{"before":"52cc0bcc139718be5598c8688b6779fbabc158de","after":"7da11ac02791c4a97bd9140a2b5b0b8c17524328","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-12T15:36:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: add NamespaceConstants cop","shortMessageHtmlLink":"WIP: add NamespaceConstants cop"}},{"before":"869082ad3218dcd55dd3e43ef95341ad264029c5","after":null,"ref":"refs/heads/dev/honor-split-rubocop-gems","pushedAt":"2024-02-12T02:39:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Drenmi","name":"Ted Johansson","path":"/Drenmi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5259935?s=80&v=4"}},{"before":"4264eab9650f62bb4485302f8dce33a8389d6e0b","after":"30b29301e308eece3428d52b12f8a6830eda5cc0","ref":"refs/heads/main","pushedAt":"2024-02-12T02:39:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Drenmi","name":"Ted Johansson","path":"/Drenmi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5259935?s=80&v=4"},"commit":{"message":"DEV: Honor split RuboCop gems (#31)\n\nRuboCop RSpec used to contain departments for Capybara and FactoryBot cops, but those are being split out into rubocop-capybara and rubocop-factory_bot gems respectively. This change updates our gemspec and configuration files to reflect that.","shortMessageHtmlLink":"DEV: Honor split RuboCop gems (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1749185447\" data-permission-text=\"Title is private\" data-url=\"https://github.com/discourse/rubocop-discourse/issues/31\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/discourse/rubocop-discourse/pull/31/hovercard\" href=\"https://github.com/discourse/rubocop-discourse/pull/31\">#31</a>)"}},{"before":"422feceae191e70e9162be9a7e5750b0b6a35184","after":"52cc0bcc139718be5598c8688b6779fbabc158de","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-08T17:37:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: don’t run on specs","shortMessageHtmlLink":"WIP: don’t run on specs"}},{"before":"f36eee88a88b7d7da7703545fc109cfe748505d9","after":"422feceae191e70e9162be9a7e5750b0b6a35184","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-08T17:35:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: add cop to namespace methods","shortMessageHtmlLink":"WIP: add cop to namespace methods"}},{"before":"c1ebfa47c63d833314c36f085939ed36f211fea2","after":"f36eee88a88b7d7da7703545fc109cfe748505d9","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-07T16:49:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: style","shortMessageHtmlLink":"WIP: style"}},{"before":"f3c9c93f3b20c2f62de15a89af09167e9a87e9ba","after":"c1ebfa47c63d833314c36f085939ed36f211fea2","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-07T16:43:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: specific error when calling `DiscourseEvent.on` outside of `plugin.rb`","shortMessageHtmlLink":"WIP: specific error when calling <code>DiscourseEvent.on</code> outside of `plug…"}},{"before":"6717fd4f40eb5dbf57ebde5aee2231511e1e8ee5","after":"f3c9c93f3b20c2f62de15a89af09167e9a87e9ba","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-07T15:53:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: don't limit DiscourseEvent cop to plugin.rb","shortMessageHtmlLink":"WIP: don't limit DiscourseEvent cop to plugin.rb"}},{"before":"f7c923da0ba5a4a06c0930ce1b5b9c0144d34c98","after":"6717fd4f40eb5dbf57ebde5aee2231511e1e8ee5","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-07T14:39:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: Add cop for DiscourseEvent.on","shortMessageHtmlLink":"WIP: Add cop for DiscourseEvent.on"}},{"before":"b828990020fc1b4605bc246de24f2db7101f94bd","after":"f7c923da0ba5a4a06c0930ce1b5b9c0144d34c98","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-07T09:32:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: fix path traversal bug","shortMessageHtmlLink":"WIP: fix path traversal bug"}},{"before":"c38a950ea754425b107c6c797fbf05799e0fb25b","after":"b828990020fc1b4605bc246de24f2db7101f94bd","ref":"refs/heads/loic-plugins-rules","pushedAt":"2024-02-06T16:58:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Flink","name":"Loïc Guitaut","path":"/Flink","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5648?s=80&v=4"},"commit":{"message":"WIP: don't override exclude","shortMessageHtmlLink":"WIP: don't override exclude"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAECN8ragA","startCursor":null,"endCursor":null}},"title":"Activity · discourse/rubocop-discourse"}