Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: raise error if no data available to Instagram engine #439

Merged
merged 1 commit into from Nov 20, 2020

Conversation

jbrw
Copy link
Contributor

@jbrw jbrw commented Nov 19, 2020

Raise an error if no oembed.data is found (e.g., if you have an invalid token). This will make the onebox generation fail, and return an empty onebox. Discourse itself will fallback to using the original link if the onebox is empty.

@jbrw jbrw merged commit 317f6ee into master Nov 20, 2020
@jbrw jbrw deleted the instagram-error-on-empty-data branch November 20, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants