FIX: reword whitelist to allowlist #430
Conversation
There was a problem hiding this comment.
Can we take this opportunity and instead of doing just find-and-replace rename stuff so it reads better? E.g.
"get away with just allowlisting the URL in" ➡️ "get away with just allowing the URL in"
self.default_allowlist ➡️ self.default_allowed_domains
self.twitter_label_allowlist ➡️ self.allowed_twitter_labels
etc etc
There was a problem hiding this comment.
This is a breaking change right - which is OK I just want to make sure we're all on the same page.
For example Discourse has references to WhitelistedGenericOnebox - I assume we'll get around this by using a version bump and upgrading Discourse at the same time as the gem?
|
@eviltrout yes, that is exactly the plan. I started working on a similar change for Discourse and noticed that I need to change that gem first. |
lis2
force-pushed
the
allowlist
branch
2 times, most recently
from
f97ff55
to
d2f61fe
Compare
The version was bumped to 2.0.0 as this change is not backward compatible
The version was bumped to 2.0.0 as this change is not backward compatible