FIX: Fix handling of multi-cookie responses #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
suggested changes
Jun 29, 2020
FIX: Correctly parse relative redirects using Addressable Also rename 'header' to 'redir_header' to deconflict with 'headers' parameter Add tests for redirect handling
eviltrout
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: Correctly parse relative redirects using Addressable
Also rename 'header' to 'redir_header' to deconflict with 'headers' parameter
We were slamming cookies together, such that the last parameter of one cookie would bleed into the name of the next. Medium.com was not happy with this arrangement.