FIX: Scheduler failed to run any jobs after Redis flush #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Oct 14, 2020
SamSaffron
reviewed
Oct 14, 2020
spec/mini_scheduler/manager_spec.rb
Outdated
| expect(queued_jobs(manager, with_hostname: false)).to include(Testing::SuperLongJob) | ||
| expect(queued_jobs(manager, with_hostname: true)).to include(Testing::PerHostJob) | ||
|
|
||
| redis.flushdb |
There was a problem hiding this comment.
flushdb kind of makes me nervous, is there any way you can be more surgical here? Maybe if all our keys are prefixed just delete keys with that prefix? do we flushdb much in our specs?
There was a problem hiding this comment.
I think we flush a couple of times in Discourse core. Anyway, I pushed a new version which deletes only keys with the _scheduler_ prefix.
|
Nice change and I support the naming change as well! |
This adds a check that runs every 60 seconds. It schedules all available jobs for a queue if the keys of the per host queue and the global queue are missing from Redis.
gschlager
force-pushed
the
fix/recover-from-redis-flush
branch
from
5aaffc2
to
77267ee
Compare
|
Looks good to me... merge away |
SamSaffron
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check that runs every 60 seconds. It schedules all available jobs for a queue if the keys of the per host queue and the global queue are missing from Redis.