Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Merge messages differing only by numbers #118

Merged
merged 3 commits into from Aug 31, 2020
Merged

Conversation

CvX
Copy link
Contributor

@CvX CvX commented May 16, 2020

Might be a bit heavy-handed, since it would also merge messages like Unhandled error 404 and Unhandled error 422, but that's an ok trade off imo.

lib/logster/message.rb Outdated Show resolved Hide resolved
@SamSaffron
Copy link
Member

@OsamaSayegh can you review?

Copy link
Member

@OsamaSayegh OsamaSayegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

FWIW we do have grouping patterns which you can see and add new ones via the UI at /settings. I do realize this PR does a different thing, but I just wanted to make sure you're aware of it

@OsamaSayegh
Copy link
Member

I don't know what happened here or why this has not been merged yet, but I'm going to merge it now 😂

@OsamaSayegh OsamaSayegh merged commit 8e067d9 into master Aug 31, 2020
@OsamaSayegh OsamaSayegh deleted the merge-similar branch August 31, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants