FEATURE: Copy button for messages #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamSaffron
reviewed
Jan 16, 2020
| @@ -70,6 +70,18 @@ def add_with_opts(severity, message = nil, progname = progname(), opts = nil, &b | |||
| message = message.scrub | |||
| end | |||
|
|
|||
| # we want to get the backtrace as early as possible so that logster's | |||
|
looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new button that copies enough details about the message to debug/fix it. This is useful if you want a quick way to share a message with your team.
Currently the button copies 3 things:
HTTP_HOSTfrom envShould we copy anything else from env @SamSaffron?
Screenshot:
There is also a small improvement to backtraces in this PR: currently when you log a message in your app code (for exmaple:
Rails.logger.warn("blah blah"), you'll notice the first few frames in the backtrace are Logster's own method calls. This PR should stop that and from now on the first frame in the backtrace should be the method where you logged the message in your app.