Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Solve All button for messages grouped by pattern #105

Merged
merged 1 commit into from Jan 13, 2020
Merged

FEATURE: Solve All button for messages grouped by pattern #105

merged 1 commit into from Jan 13, 2020

Conversation

OsamaSayegh
Copy link
Member

This adds a button when you view messages grouped by pattern that allows you to solve all the messages contained in the group.

This also fixes a bug where the solve button wouldn't show up for individual (un-grouped) messages unless you switched to the env tab. This bug is a recent regression from 83f1ac3 where we started deferring sending env to the client until the user switches to the env tab for performance reason.

The whole solve functionality depends on application_version being available in the message's env, so if env has been loaded, we show the solve button if env contains an application_version attribute. However, if env hasn't been loaded, we check if Logster is provided with application_version via the Logster.config.application_version config and show the button only if it's configured (i.e. it has a value) because it's very likely that the message's env contains an application_version attribute if Logster is configured with one.

@SamSaffron
Copy link
Member

Oh this is nice! thanks, feel free to merge! reasoning sounds 100% correct to me.

@OsamaSayegh OsamaSayegh merged commit 0e45201 into discourse:master Jan 13, 2020
@OsamaSayegh OsamaSayegh deleted the fix-solve branch January 13, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants