chore: fix CVE #132
Merged
chore: fix CVE #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
force-pushed
the
chore/fix-cve
branch
from
6443eb4
to
5d3cef0
Compare
kyranet
requested changes
Jun 21, 2022
Comment on lines
+91
to
+92
| Napi::TypeError::New(env, "Provided input needs to be a buffer").ThrowAsJavaScriptException(); | ||
| return env.Null(); |
There was a problem hiding this comment.
Should we not use the NAPI_THROW macro?
There was a problem hiding this comment.
Also, is a return value needed? This method doesn't have a return at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #131 and #49
Semantic versioning classification: