From 217cdd3a8e9ae89a2c014db23b0d50e6e147ce69 Mon Sep 17 00:00:00 2001 From: almeidx Date: Wed, 9 Nov 2022 11:08:50 +0000 Subject: [PATCH] fix(MessageMentions): add InGuild generic --- packages/discord.js/typings/index.d.ts | 8 ++++---- packages/discord.js/typings/index.test-d.ts | 9 +++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts index 437db959f4d5..a145dee05213 100644 --- a/packages/discord.js/typings/index.d.ts +++ b/packages/discord.js/typings/index.d.ts @@ -1795,7 +1795,7 @@ export class Message extends Base { public id: Snowflake; public interaction: MessageInteraction | null; public get member(): GuildMember | null; - public mentions: MessageMentions; + public mentions: MessageMentions; public nonce: string | number | null; public get partial(): false; public get pinnable(): boolean; @@ -1954,7 +1954,7 @@ export class MessageFlagsBitField extends BitField { public static resolve(bit?: BitFieldResolvable): number; } -export class MessageMentions { +export class MessageMentions { private constructor( message: Message, users: APIUser[] | Collection, @@ -1970,9 +1970,9 @@ export class MessageMentions { public get channels(): Collection; public readonly client: Client; public everyone: boolean; - public readonly guild: Guild; + public readonly guild: If; public has(data: UserResolvable | RoleResolvable | ChannelResolvable, options?: MessageMentionsHasOptions): boolean; - public get members(): Collection | null; + public get members(): If>; public get parsedUsers(): Collection; public repliedUser: User | null; public roles: Collection; diff --git a/packages/discord.js/typings/index.test-d.ts b/packages/discord.js/typings/index.test-d.ts index c78de7c6715d..75778cc79578 100644 --- a/packages/discord.js/typings/index.test-d.ts +++ b/packages/discord.js/typings/index.test-d.ts @@ -148,6 +148,7 @@ import { RoleSelectMenuInteraction, ChannelSelectMenuInteraction, MentionableSelectMenuInteraction, + MessageMentions, } from '.'; import { expectAssignable, expectNotAssignable, expectNotType, expectType } from 'tsd'; import type { ContextMenuCommandBuilder, SlashCommandBuilder } from '@discordjs/builders'; @@ -349,6 +350,10 @@ client.on('messageCreate', async message => { expectType(message.channel); expectType(message.guild); expectType(message.member); + + expectType>(message.mentions); + expectType(message.guild); + expectType>(message.mentions.members); } expectType(message.channel); @@ -1425,6 +1430,10 @@ declare const guildChannelManager: GuildChannelManager; expectType(message.guild); expectType(message.guildId); expectType(message.channel.messages.channel); + + expectType>(message.mentions); + expectType(message.mentions.guild); + expectType(message.mentions.members); } declare const guildForumThreadManager: GuildForumThreadManager;