Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make builders types great again #9292

Closed
Jiralite opened this issue Mar 28, 2023 · 0 comments · Fixed by #10026
Closed

Make builders types great again #9292

Jiralite opened this issue Mar 28, 2023 · 0 comments · Fixed by #10026
Assignees
@vladfrangu @Qjuh
Labels
bug has PR packages:builders refactor

Comments

@Jiralite
Copy link
Member

Jiralite commented Mar 28, 2023 •
edited

Which package is this bug report for?

builders

Issue description

Builders my beloved... unfortunately, we cannot tolerate amazing types anymore. Here is an example taken from https://discordjs.dev/docs/packages/builders/main/SharedSlashCommandOptions:Class:

Complex builder type

Complex builder type

The types should be refactored to be something more human-readable as they appear in the public API.

Code sample

No response

Package version

1.5.1-dev

Node.js version

N/A

Operating system

No response

Priority this issue should have

Medium (should be fixed soon)

Which partials do you have configured?

Not applicable (subpackage bug)

Which gateway intents are you subscribing to?

Not applicable (subpackage bug)

I have tested this issue on a development release

47da24f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladfrangu vladfrangu

@Qjuh Qjuh

Labels
bug has PR packages:builders refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: make builders types great again Qjuh/discord.js
3 participants
@vladfrangu @Jiralite @Qjuh