Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent crash on no select menu option #8881

Merged
merged 3 commits into from Dec 1, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #8880 - resolved data is not sent if nothing is sent.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 10:50AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
discord-js-guide ⬜️ Ignored (Inspect) Dec 1, 2022 at 10:50AM (UTC)

@Jiralite Jiralite added this to the discord.js v14.8 milestone Nov 29, 2022
zapteryx added a commit to ZPTXDev/Quaver that referenced this pull request Nov 30, 2022
temporarily patching from PR discordjs/discord.js#8881
who knows how long it'll take for this to make it to release
@kodiakhq kodiakhq bot merged commit 11d195d into discordjs:main Dec 1, 2022
@Jiralite Jiralite deleted the fix/select-menu-no-option branch December 1, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bot crashes upon deselecting Channel SelectMenu
5 participants