Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove casts when using makeURLSearchParams() #8877

Merged
merged 1 commit into from Nov 28, 2022
Merged

fix: remove casts when using makeURLSearchParams() #8877

merged 1 commit into from Nov 28, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Nov 28, 2022

Please describe the changes this PR makes and why it should be merged:
These casts are no longer needed since

Status and versioning classification:

@vercel
Copy link

vercel bot commented Nov 28, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Nov 28, 2022 at 9:36AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Nov 28, 2022 at 9:36AM (UTC)

@Jiralite Jiralite mentioned this pull request Nov 28, 2022
Merged
kyranet
kyranet approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happiness++

@iCrawl iCrawl merged commit 7430c8e into discordjs:main Nov 28, 2022
@almeidx almeidx deleted the rest-casts branch November 28, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:core semver:patch
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @iCrawl @kyranet @suneettipirneni @Jiralite