Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed react/astro/guide/discord.js build, updated dependencies, fix crawlvatar #8861

Merged
merged 1 commit into from Nov 25, 2022

Conversation

favna
Copy link
Contributor

@favna favna commented Nov 24, 2022

Please describe the changes this PR makes and why it should be merged:

  • Fixed the CI on main
  • Fixed Crawl's avatar in the docs (he updated it on Discord)
  • Fixed Astro config reading proper node_modules

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 9:24AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 9:24AM (UTC)

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #8861 (d2b4a50) into main (65bc0ad) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d2b4a50 differs from pull request most recent head 627c4d4. Consider uploading reports for the commit 627c4d4 to get more accurate results

@@           Coverage Diff           @@
##             main    #8861   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files          96       96           
  Lines        9475     9475           
  Branches     1137     1137           
=======================================
  Hits         8114     8114           
  Misses       1319     1319           
  Partials       42       42           
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.65% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <100.00%> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/RequestManager.ts 90.26% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favna favna changed the title fix: fixed react/astro/guide build, updated dependencies, fix crawlvatar fix: fixed react/astro/guide/discord.js build, updated dependencies, fix crawlvatar Nov 25, 2022
@iCrawl iCrawl merged commit d0c8256 into discordjs:main Nov 25, 2022
@favna favna deleted the fix/react-astro-build branch November 26, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants