Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify ActionRowBuilder for components #8834

Merged
merged 2 commits into from Nov 19, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 15, 2022

Please describe the changes this PR makes and why it should be merged:
This pull request resolves #8833 - ActionRowOptions[] was not the correct type here, whatever it was. It should (obviously) accept ActionRowBuilder[].

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Nov 19, 2022 at 9:43PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Nov 19, 2022 at 9:43PM (UTC)

@cm-ayf
Copy link
Contributor

cm-ayf commented Nov 16, 2022

Thank you very much for fixing the issue.

I actually expected ActionRowOptions to be something close to MessageActionRowOptions in v13 (which seems to have disappeared upgrading to v14) or ActionRowData in the index.d.ts.

It also seems that ActionRowBuilder[] should be accepted, by the way.

@kodiakhq kodiakhq bot merged commit 8ed5c1b into discordjs:main Nov 19, 2022
@Jiralite Jiralite deleted the docs/bad-action-row-options branch November 19, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Definition of ActionRowOptions does not exist in packages/discord.js
5 participants