Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Webhook): add channel property #8812

Merged
merged 5 commits into from Nov 26, 2022

Conversation

MrMythicalYT
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR adds a channel getter for webhooks
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Nov 20, 2022 at 0:09AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Nov 20, 2022 at 0:09AM (UTC)

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Webhook.js Outdated Show resolved Hide resolved
@Jiralite Jiralite added this to the discord.js v14.7 milestone Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #8812 (ccb21bb) into main (b2658ce) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8812      +/-   ##
==========================================
- Coverage   85.81%   85.63%   -0.18%     
==========================================
  Files          91       96       +5     
  Lines        9254     9475     +221     
  Branches     1125     1137      +12     
==========================================
+ Hits         7941     8114     +173     
- Misses       1271     1319      +48     
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.65% <ø> (-1.35%) ⬇️
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <ø> (-0.09%) ⬇️
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/components/Components.ts 87.87% <0.00%> (-12.13%) ⬇️
packages/rest/src/lib/utils/utils.ts 97.33% <0.00%> (-0.48%) ⬇️
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.07% <0.00%> (-0.37%) ⬇️
packages/collection/src/collection.ts 100.00% <0.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <0.00%> (ø)
...ders/src/components/selectMenu/SelectMenuOption.ts
...s/builders/src/components/selectMenu/SelectMenu.ts
...ilders/src/components/selectMenu/BaseSelectMenu.ts 92.18% <0.00%> (ø)
...ilders/src/components/selectMenu/RoleSelectMenu.ts 90.32% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Nov 5, 2022

Can you format it? yarn format
as djs uses different syntax

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor nits

packages/discord.js/src/structures/Webhook.js Show resolved Hide resolved
packages/discord.js/src/structures/Webhook.js Show resolved Hide resolved
packages/discord.js/src/structures/Webhook.js Outdated Show resolved Hide resolved
Co-authored-by: Aura Román <kyradiscord@gmail.com>
@iCrawl iCrawl merged commit decbce4 into discordjs:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants