feat(SelectMenuInteractions): add values property
#8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
didinele
requested changes
Nov 2, 2022
packages/discord.js/src/structures/MentionableSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/ChannelSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/RoleSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/UserSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
…into fix-newselects
kyranet
requested changes
Nov 19, 2022
packages/discord.js/src/structures/MentionableSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
…ction.js Co-authored-by: Aura Román <kyradiscord@gmail.com>
kyranet
approved these changes
Nov 19, 2022
vladfrangu
approved these changes
Nov 19, 2022
kyranet
changed the title
values property
kyranet
changed the title
values propertyvalues property
Codecov Report
@@ Coverage Diff @@
## main #8805 +/- ##
==========================================
- Coverage 85.61% 85.59% -0.02%
==========================================
Files 96 95 -1
Lines 9459 9446 -13
Branches 1134 1129 -5
==========================================
- Hits 8098 8085 -13
Misses 1319 1319
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Add values property to interactions
And stop members, roles displaying as null ( as they cant be )
Status and versioning classification: