Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InteractionResponses): add message parameter #8773

Merged
merged 10 commits into from Oct 31, 2022

Conversation

MrMythicalYT
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR adds a parameter to InteractionResponses#editReply() that lets you choose which message to edit.
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 30, 2022 at 11:18AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 30, 2022 at 11:18AM (UTC)

@MrMythicalYT MrMythicalYT changed the title feat(InteractionResponses): add message parameter feat(InteractionResponses): add message parameter to editReply Oct 20, 2022
@monbrey
Copy link
Member

monbrey commented Oct 21, 2022

Why not make this change to deleteReply also?

@MrMythicalYT
Copy link
Contributor Author

Why not make this change to deleteReply also?

This was originally meant to make it easier for response editing. For consistency, I will add it to fetchReply and deleteReply

@MrMythicalYT MrMythicalYT changed the title feat(InteractionResponses): add message parameter to editReply feat(InteractionResponses): add message parameter Oct 21, 2022
@MrMythicalYT MrMythicalYT requested review from kyranet and removed request for iCrawl, SpaceEEC and kyranet October 27, 2022 11:15
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #8773 (df4653b) into main (e7cbc1b) will increase coverage by 20.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #8773       +/-   ##
===========================================
+ Coverage   65.24%   85.81%   +20.56%     
===========================================
  Files           4       91       +87     
  Lines         446     9254     +8808     
  Branches        8     1125     +1117     
===========================================
+ Hits          291     7941     +7650     
- Misses        155     1271     +1116     
- Partials        0       42       +42     
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 81.53% <ø> (?)
rest 92.06% <ø> (?)
util 100.00% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.70% <ø> (?)
ws 59.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/receive/AudioReceiveStream.ts 100.00% <0.00%> (ø)
packages/builders/src/messages/embed/Embed.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/REST.ts 98.87% <0.00%> (ø)
packages/rest/src/lib/errors/DiscordAPIError.ts 96.42% <0.00%> (ø)
packages/voice/src/util/Secretbox.ts 33.33% <0.00%> (ø)
packages/rest/src/lib/CDN.ts 97.74% <0.00%> (ø)
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/utils/utils.ts 97.81% <0.00%> (ø)
...trategies/context/SimpleContextFetchingStrategy.ts 71.42% <0.00%> (ø)
packages/util/src/types.ts 100.00% <0.00%> (ø)
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 8b400ca into discordjs:main Oct 31, 2022
@MrMythicalYT MrMythicalYT deleted the feat/edit-reply branch October 31, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants