Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make WebSocketShard.lastPingTimestamp public #8768

Merged
merged 3 commits into from Nov 2, 2022

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Oct 19, 2022

@ImRodry suggestion

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Nov 2, 2022 at 1:22PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Nov 2, 2022 at 1:22PM (UTC)

@iCrawl iCrawl changed the title Make WebSocketShard.lastPingTimestamp public docs: make WebSocketShard.lastPingTimestamp public Oct 31, 2022
@kyranet
Copy link
Member

kyranet commented Nov 1, 2022

This needs a rebase.

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #8768 (daf5cab) into main (5152abf) will increase coverage by 0.65%.
The diff coverage is n/a.

❗ Current head daf5cab differs from pull request most recent head b40dfbb. Consider uploading reports for the commit b40dfbb to get more accurate results

@@            Coverage Diff             @@
##             main    #8768      +/-   ##
==========================================
+ Coverage   85.16%   85.81%   +0.65%     
==========================================
  Files          83       91       +8     
  Lines        7965     9254    +1289     
  Branches      942     1125     +183     
==========================================
+ Hits         6783     7941    +1158     
- Misses       1140     1271     +131     
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (?)
builders 100.00% <ø> (+1.34%) ⬆️
collection 100.00% <ø> (?)
proxy 81.53% <ø> (?)
rest 92.06% <ø> (+0.08%) ⬆️
util 100.00% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <0.00%> (ø)
...ilders/src/components/selectMenu/RoleSelectMenu.ts
...ilders/src/components/selectMenu/UserSelectMenu.ts
...rc/components/selectMenu/StringSelectMenuOption.ts
...ers/src/components/selectMenu/ChannelSelectMenu.ts
...ilders/src/components/selectMenu/BaseSelectMenu.ts
...ders/src/components/selectMenu/StringSelectMenu.ts
...src/components/selectMenu/MentionableSelectMenu.ts
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 68c9cb3 into discordjs:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants