Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Message#bulkDeletable #8760

Merged
merged 9 commits into from Nov 6, 2022

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Oct 16, 2022

Please describe the changes this PR makes and why it should be merged:
This PR adds Message#bulkDeletable

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Oct 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 3:47AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 3:47AM (UTC)

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is missing direct message channel checks.

Also, if possible, can you state a use case for this as the bulk delete method we have already filters out ids that cannot be bulk deleted.

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as with #8761 (review), I'll approve once those requests are resolved on both PRs.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #8760 (d265b1b) into main (6e348ff) will increase coverage by 0.23%.
The diff coverage is 87.62%.

@@            Coverage Diff             @@
##             main    #8760      +/-   ##
==========================================
+ Coverage   85.22%   85.46%   +0.23%     
==========================================
  Files          77       90      +13     
  Lines        6715     9363    +2648     
  Branches      877     1117     +240     
==========================================
+ Hits         5723     8002    +2279     
- Misses        953     1319     +366     
- Partials       39       42       +3     
Flag Coverage Δ
brokers 65.24% <ø> (?)
builders 98.65% <87.87%> (-1.35%) ⬇️
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <82.35%> (?)
util ?
utilities ?
voice 63.70% <ø> (ø)
ws 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.07% <50.00%> (ø)
packages/builders/src/components/Components.ts 87.87% <60.00%> (-12.13%) ⬇️
...ers/src/components/selectMenu/ChannelSelectMenu.ts 63.49% <63.49%> (ø)
...src/components/selectMenu/MentionableSelectMenu.ts 90.32% <90.32%> (ø)
...ilders/src/components/selectMenu/RoleSelectMenu.ts 90.32% <90.32%> (ø)
...ilders/src/components/selectMenu/UserSelectMenu.ts 90.32% <90.32%> (ø)
...ilders/src/components/selectMenu/BaseSelectMenu.ts 92.18% <92.18%> (ø)
packages/rest/src/lib/utils/utils.ts 97.33% <92.30%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <100.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <100.00%> (ø)
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants