Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resume gateway url #8750

Closed
gamer0mega opened this issue Oct 14, 2022 · 0 comments · Fixed by #8784
Closed

Support resume gateway url #8750

gamer0mega opened this issue Oct 14, 2022 · 0 comments · Fixed by #8784

Comments

@gamer0mega
Copy link

Which package is the feature request for?

discord.js

Feature

Approximately a month ago, Discord introduced resume gateway url inside of the ready event, but it looks like discord.js does not have it (NOT the separate ws package)
I have browsed through the code and it appears that WebSocketShard always uses the gateway property of its manager which is wss://gateway.discord.gg/, even when it has to resume, but the ws package has it.

Ideal solution or implementation

Store the resume gateway url inside of the WebSocketShard, and when it's the time to reconnect and resume, use it instead of WebSocketShardManager#gateway which comes from the /gateway/bot endpoint.

Alternative solutions or implementations

No response

Other context

No response

@SpaceEEC SpaceEEC linked a pull request Oct 29, 2022 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants