Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Embed): use embedLength function from builders #8735

Merged
merged 1 commit into from Oct 12, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 11, 2022

Please describe the changes this PR makes and why it should be merged:
Uses the embedLength() function from /builders in Embed#length to reduce code duplication

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 11, 2022 at 2:46PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 11, 2022 at 2:46PM (UTC)

@iCrawl iCrawl merged commit cb3826c into discordjs:main Oct 12, 2022
@almeidx almeidx deleted the discord.js/embed-length branch October 12, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants