Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocketShard): dispatch race condition #8731

Merged
merged 1 commit into from Oct 10, 2022

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Closes #8726

This is quite the "easy fix", by just removing the guard on dispatch events, since it was quite frankly unnecessary for a lib as low level as ws is.

Possibly related to #8558 (i.e. might improve the behavior there; otherwise that issue will need additional research)

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 10, 2022 at 2:48PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 10, 2022 at 2:48PM (UTC)

@Jiralite Jiralite added this to the ws v1.3 milestone Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #8731 (5dbd96e) into main (3ed668e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #8731      +/-   ##
==========================================
+ Coverage   86.83%   86.85%   +0.01%     
==========================================
  Files          87       87              
  Lines        8810     8808       -2     
  Branches     1117     1117              
==========================================
  Hits         7650     7650              
+ Misses       1118     1116       -2     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 92.06% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 23.39% <0.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite removed this from the ws v1.3 milestone Oct 10, 2022
@iCrawl iCrawl added this to the ws v0.5 milestone Oct 10, 2022
@iCrawl iCrawl merged commit c2b6777 into discordjs:main Oct 10, 2022
@iCrawl iCrawl modified the milestones: ws v0.5, ws v0.4.1 Oct 10, 2022
@didinele didinele deleted the fix/ws-race-condition branch October 13, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Not consistently receiving all GUILD_CREATE events
4 participants