Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Client): don't auth for webhook fetches with token #8709

Merged
merged 2 commits into from Oct 6, 2022

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Oct 6, 2022

Please describe the changes this PR makes and why it should be merged:

Fixes an oversight from moving to /rest. Any request that sends its own token should be set to auth false to avoid erroneously unsetting the client token.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 6, 2022 at 7:37PM (UTC)

@Jiralite Jiralite added this to the discord.js v14.6 milestone Oct 6, 2022
@kodiakhq kodiakhq bot merged commit 01d75c8 into discordjs:main Oct 6, 2022
@ckohen ckohen deleted the fix/fetch-webhook-deauth branch October 7, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants