Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Error to DiscordjsError internally #8706

Merged
merged 3 commits into from Oct 6, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 5, 2022

Please describe the changes this PR makes and why it should be merged:
Renamed the Error, TypeError, and RangeError internally to DiscordjsError, DiscordjsTypeError, and DiscordjsRangeError. They were already being exported under this name

Hopefully prevents issues like these to not happen again:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 9:20AM (UTC)

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #8706 (466c9e7) into main (e745b95) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 466c9e7 differs from pull request most recent head 5d6c555. Consider uploading reports for the commit 5d6c555 to get more accurate results

@@            Coverage Diff             @@
##             main    #8706      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files          87       87              
  Lines        8815     8814       -1     
  Branches     1103     1103              
==========================================
- Hits         7657     7656       -1     
  Misses       1116     1116              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 92.07% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.83% <ø> (ø)
ws 59.86% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 23.18% <0.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview October 6, 2022 09:20 Inactive
@kodiakhq kodiakhq bot merged commit aec44a0 into discordjs:main Oct 6, 2022
@almeidx almeidx deleted the discord.js/rename-error branch October 6, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants