Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw discord.js errors correctly #8697

Merged
merged 2 commits into from Oct 5, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Oct 3, 2022

Please describe the changes this PR makes and why it should be merged:
Some errors were not thrown as a discord.js error due to the missing Error import, resulting in a global error thrown where our customisability becomes lost.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 0:28AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 5, 2022 12:28 Inactive
@kodiakhq kodiakhq bot merged commit ace974f into discordjs:main Oct 5, 2022
@Jiralite Jiralite deleted the fix/error-imports branch October 5, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants