Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change token in readme to constant #8688

Merged
merged 4 commits into from Oct 9, 2022

Conversation

jeongnaehyeok
Copy link
Contributor

@jeongnaehyeok jeongnaehyeok commented Sep 30, 2022

Please describe the changes this PR makes and why it should be merged:
I was confused when I saw the guide code in README.md. Cuz 'CLIENT_ID' is a constant expression but 'token' is not, I pondered for a moment what was wrong. I think this should be expressed in the same way. So I modify this.
Status and versioning classification:
Modify 'token' to 'TOKEN' in all example codes

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 9, 2022 at 9:20PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 9, 2022 at 9:20PM (UTC)

@vercel vercel bot temporarily deployed to Preview September 30, 2022 10:47 Inactive
@jaw0r3k
Copy link
Contributor

jaw0r3k commented Sep 30, 2022

um as u said to 'TOKEN'
not to variable ( bc its not defined )

README.md Show resolved Hide resolved
@jeongnaehyeok jeongnaehyeok requested review from jaw0r3k and removed request for vladfrangu, iCrawl, kyranet and SpaceEEC October 3, 2022 02:56
@vercel vercel bot temporarily deployed to Preview October 4, 2022 02:01 Inactive
@kodiakhq kodiakhq bot merged commit 0a9d57b into discordjs:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants