Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ForumChannel): add defaultSortOrder #8633

Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 18, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Sep 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 1, 2022 at 1:54PM (UTC)

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #8633 (1e9c2f8) into main (c69f512) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8633      +/-   ##
==========================================
+ Coverage   86.79%   86.83%   +0.04%     
==========================================
  Files          85       85              
  Lines        8777     8799      +22     
  Branches     1109     1113       +4     
==========================================
+ Hits         7618     7641      +23     
+ Misses       1117     1116       -1     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 81.53% <100.00%> (+1.06%) ⬆️
rest 92.08% <100.00%> (+0.07%) ⬆️
utilities 100.00% <ø> (ø)
voice 63.83% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/proxy/src/handlers/proxyRequests.ts 73.91% <100.00%> (+2.27%) ⬆️
packages/rest/src/lib/RequestManager.ts 90.34% <100.00%> (+0.09%) ⬆️
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.44% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@almeidx almeidx force-pushed the discord.js/forum-default-sort-order branch from 02aeb3f to 943f0c1 Compare September 18, 2022 14:46
@almeidx

This comment was marked as outdated.

@almeidx almeidx closed this Sep 20, 2022
@almeidx almeidx reopened this Sep 22, 2022
@Jiralite Jiralite mentioned this pull request Sep 24, 2022
@almeidx almeidx force-pushed the discord.js/forum-default-sort-order branch from bdbb0cb to 1e9c2f8 Compare October 1, 2022 13:54
@almeidx almeidx marked this pull request as ready for review October 1, 2022 13:55
@SpaceEEC SpaceEEC removed the blocked label Oct 1, 2022
@kodiakhq kodiakhq bot merged commit 883f6e9 into discordjs:main Oct 1, 2022
@almeidx almeidx deleted the discord.js/forum-default-sort-order branch October 1, 2022 14:01
@Jiralite Jiralite removed this from the discord.js v14.4 milestone Oct 1, 2022
@Jiralite Jiralite added this to the discord.js v14.6 milestone Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants