feat(GuildChannelManager): add .addFollower() method
#8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Jiralite
requested changes
Aug 28, 2022
SpaceEEC
approved these changes
Sep 11, 2022
vladfrangu
approved these changes
Sep 11, 2022
kyranet
requested changes
Sep 11, 2022
|
Hey @Syjalo, are you still maintaining this pull request? |
|
@Syjalo is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: A. Román <kyradiscord@gmail.com>
Co-authored-by: A. Román <kyradiscord@gmail.com>
Syjalo
force-pushed
the
feat/add-GuildChannelManager#addFollower()
branch
from
e898e94
to
843986e
Compare
|
I suggest you add this method to the GuildChannel class and add typings to make sure the channel type is GuildAnnouncement. |
|
It shouldn't be added to that class as not all guild channels may do that. Only one type of guild channel may do that, and its functionality already exists. |
kyranet
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds
GuildChannelManager#addFollower()method.Status and versioning classification: