Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper format for @link text #8384

Merged
merged 1 commit into from Jul 28, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jul 28, 2022

Please describe the changes this PR makes and why it should be merged:

Previous PR forgot the | seperator for link text. Ref: https://tsdoc.org/pages/tags/link/

Status and versioning classification:

Please move lines that apply to you out of the comment:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 6:07PM (UTC)

@imranbarbhuiya
Copy link
Contributor

imranbarbhuiya commented Jul 28, 2022

/rest also has some link tags without | so u can change that too.

* The {@link https://discord.com/developers/docs/reference#message-formatting-timestamp-styles message formatting timestamp styles} supported by Discord

* The {@link https://undici.nodejs.org/#/docs/api/Agent Agent} to use for the request.

* The {@link https://undici.nodejs.org/#/docs/api/Agent Agent} for all requests

@vercel vercel bot temporarily deployed to Preview July 28, 2022 17:50 Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #8384 (0f9af18) into main (5494791) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8384   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          87       87           
  Lines        8221     8221           
  Branches     1098     1098           
=======================================
  Hits         7103     7103           
  Misses       1075     1075           
  Partials       43       43           
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <100.00%> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 60.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/messages/formatters.ts 100.00% <100.00%> (ø)
packages/collection/src/collection.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@suneettipirneni
Copy link
Member Author

/rest also has some link tags without | so u can change that too.

* The {@link https://discord.com/developers/docs/reference#message-formatting-timestamp-styles message formatting timestamp styles} supported by Discord

* The {@link https://undici.nodejs.org/#/docs/api/Agent Agent} to use for the request.

* The {@link https://undici.nodejs.org/#/docs/api/Agent Agent} for all requests

We'll focus on the other packages when the new docs site is closer to release.

@suneettipirneni suneettipirneni changed the title fix(collection): use proper format for link text fix: use proper format for link text Jul 28, 2022
@suneettipirneni suneettipirneni changed the title fix: use proper format for link text fix: use proper format for @link text Jul 28, 2022
@vercel vercel bot temporarily deployed to Preview July 28, 2022 18:07 Inactive
@iCrawl iCrawl merged commit 2655639 into discordjs:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants