Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(interaction): add locale list link #7261

Merged
merged 1 commit into from Jan 13, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Jan 12, 2022

Please describe the changes this PR makes and why it should be merged:

This PR adds a link to a list of all possible locales from Discord's documentation to Interaction#locale

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@suneettipirneni
Copy link
Member

Could you also add a LocaleString type that's a union of all the locale types?

@ImRodry
Copy link
Contributor Author

ImRodry commented Jan 12, 2022

I don’t know how often Discord adds locales but should we be the ones documenting that? I mean if they do add some the code doesn’t need to be updated but we’d need to update that typedef whereas a simple link to the API docs is always up to date

@DTrombett
Copy link
Contributor

Could you also add a LocaleString type that's a union of all the locale types?

Maybe this can be done in discord-api-types?
I think it would be good to have an enum/type of the possible locale codes

@almeidx
Copy link
Member

almeidx commented Jan 12, 2022

LocaleString could be used instead of string when/if this is released

@ImRodry
Copy link
Contributor Author

ImRodry commented Jan 12, 2022

There's no point if it's not gonna link to anything anyways right

@almeidx
Copy link
Member

almeidx commented Jan 12, 2022

I meant the TS type of it, but that can be done on a separate pull request I suppose

@iCrawl iCrawl added this to the discord.js v14 milestone Jan 13, 2022
@iCrawl iCrawl merged commit 37ec0bd into discordjs:main Jan 13, 2022
iCrawl pushed a commit that referenced this pull request Jan 13, 2022
@advaith1
Copy link
Contributor

advaith1 commented Jan 13, 2022

uh... I just moved this yesterday

@ImRodry ImRodry deleted the docs-locale-list branch January 13, 2022 17:42
@ImRodry
Copy link
Contributor Author

ImRodry commented Jan 13, 2022

Well it still works so will update when it stops doing so

@Th1983

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants