feat: rest hash and handler sweeping #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
vladfrangu
previously requested changes
Jan 12, 2022
SpaceEEC
previously requested changes
Jan 12, 2022
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
ckohen
requested changes
Jan 12, 2022
There was a problem hiding this comment.
I was going to do sweeping of handlers in djs but since we're sweeping hashes here I guess we should sweep handlers too. I do think that would be within the scope of this PR (most of the groundwork was layed long ago), but if you don't think so, I'll make that PR once this is merged
suneettipirneni
changed the title
kyranet
previously requested changes
Jan 14, 2022
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
suneettipirneni
force-pushed
the
rest/feat/hash-sweeping
branch
from
16e0705
to
123c09c
Compare
vladfrangu
previously requested changes
Jan 15, 2022
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
iCrawl
approved these changes
Jan 16, 2022
kyranet
approved these changes
Jan 17, 2022
vladfrangu
approved these changes
Jan 17, 2022
SpaceEEC
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
See discordjs/discord.js-modules#40
Sweeps hashes based on the lifetime of a given hash. Lifetimes are based on the last time a particular hash was used relative to the current data/time. In addition this sweeps inactive handlers.
This introduces new options for
REST:hashSweepInterval: The delay before each hash sweep interval.hashLifetime: The maximum amount of time a hash can exist before being swept.handlerSweepInterval: The delay before each handler sweep intervalStatus and versioning classification: