fix: ref delay for rate limited requests
#7239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
requested changes
Jan 10, 2022
suneettipirneni
force-pushed
the
fix/ref-delay
branch
from
364674f
to
4f063a5
Compare
suneettipirneni
force-pushed
the
fix/ref-delay
branch
from
4f063a5
to
1b0194b
Compare
vladfrangu
approved these changes
Jan 10, 2022
kyranet
approved these changes
Jan 10, 2022
iCrawl
approved these changes
Jan 10, 2022
SpaceEEC
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #7235
The request handler relied on awaiting
delayhere:discord.js/packages/rest/src/lib/handlers/SequentialHandler.ts
Line 278 in b2dfb2e
This works if this isn't the only code left after the event loop finishes. However if there is no other code left and the program always ends up on awaiting the delay, it will never actually
awaitbecause it's been unref'd.Status and versioning classification: