Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rest): rename attachment to file #7199

Merged
merged 1 commit into from
Jan 7, 2022
Merged

refactor(rest): rename attachment to file #7199

merged 1 commit into from
Jan 7, 2022

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jan 7, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@iCrawl iCrawl added this to the rest v1 milestone Jan 7, 2022
@iCrawl iCrawl merged commit c969cbf into discordjs:main Jan 7, 2022
@ckohen ckohen deleted the rest/attachment-file branch January 8, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
packages:rest semver:major
Projects
discord.js
Archived in project
Milestone
rest v1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ckohen @vladfrangu @iCrawl @kyranet