Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ReactionUserManager): fetch description #5382

Merged
merged 1 commit into from
Mar 29, 2021
Merged

docs(ReactionUserManager): fetch description #5382

merged 1 commit into from
Mar 29, 2021

Conversation

anandre
Copy link
Contributor

@anandre anandre commented Mar 9, 2021

Please describe the changes this PR makes and why it should be merged:
The description currently says that fetching returns all users on the reaction. This is incorrect, as there is an API limit of 100 users per fetch. This PR changes the description to better match the actual behavior.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

The description currently says that fetching returns all users on the reaction.  This is incorrect, as there is an API limit of 100 users per fetch.  This PR changes the description to better match the actual behavior.
@kyranet kyranet requested review from iCrawl and vladfrangu March 28, 2021 17:38
@iCrawl iCrawl changed the title Fix docs on fetch description docs(ReactionUserManager): fetch description Mar 29, 2021
@iCrawl iCrawl merged commit 8e8d9b4 into discordjs:stable Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants