fix(Partials): Use more user objects available from the gateway #4791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Sep 5, 2020
kyranet
reviewed
Sep 5, 2020
- Moves TYPING_START to an Action to be able to use this.getMember()
vladfrangu
requested changes
Sep 5, 2020
iCrawl
approved these changes
Sep 7, 2020
vladfrangu
approved these changes
Sep 7, 2020
kyranet
approved these changes
Sep 7, 2020
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The Gateway includes a member object wrapping a user object in
MESSAGE_REACTION_ADDandTYPING_STARTevents, if those events originated from a guild. Those were previously ignored. If available, that data is now used.Similar story for
GUILD_MEMBER_REMOVE, it includes a fulluserobject. Use that instead of just the ID.Status
Semantic versioning classification: