Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typings): remove Partial types from some events #4781

Merged
merged 1 commit into from Sep 5, 2020

Conversation

wasdennnoch
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
The typings mark more event arguments as possibly partial than required.

  • GUILD_BAN_ADD/GUILD_BAN_ADD always includes a full User object
  • GUILD_MEMBER_ADD/GUILD_MEMBERS_CHUNK always includes a full Member object
  • USER_UPDATE always includes a full User object
    • GUILD_MEMBER_UPDATE as well, which d.js-internally emits userUpdate

I've tested that the gateway indeed seems to emit full objects for those events.

As the gateway always emits full objects in those cases the d.js-emitted objects will never be partial.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit a28754b into discordjs:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants