fix(Util): throw token invalid for fetching rec. shard amount #4779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As #4778 has brough to light we currently throw the response if an invalid token is provided when fetching the recommended amount of shards from the API.
While changing the kind of error to throw here could be framed as major i am so bold to say that this can not be deliberate design (as it results in the rather unhelpful
#<Response>
being thrown) and thus will tag it as patch and consider it a fix rather than a feature.discord.js/src/util/Util.js
Lines 246 to 247 in b0ab37d
Seeing that providing an invalid token will result in a 401 response adding a line to throw TOKEN_INVALID instead if that's the case provides more context to the user but still enables other faults to be propagated.
Status
Semantic versioning classification: